Deprecate Ember.OrderedSet

emberjs · May 26, 2018 · de7e041 · de7e041
1 parent 88f3264
commit de7e041
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/packages/@ember/map/lib/ordered-set.js b/packages/@ember/map/lib/ordered-set.js
@@ -1,4 +1,4 @@
-import { assert } from '@ember/debug';
+import { assert, deprecate } from '@ember/debug';
 import { guidFor } from 'ember-utils';
 import { copyNull } from './utils';
 
@@ -14,6 +14,8 @@ import { copyNull } from './utils';
 */
 export default class OrderedSet {
   constructor() {
+    deprecate('Use of @ember/OrderedSet is deprecated. Please use native `Map` instead', false, { id: 'ember-map-deprecation', until: '3.5.0' });
+
     this.clear();
   }
 

diff --git a/packages/@ember/map/tests/map_test.js b/packages/@ember/map/tests/map_test.js
@@ -517,7 +517,9 @@ moduleFor(
       number = 42;
       string = 'foo';
 
-      map = OrderedSet.create();
+      expectDeprecation(() => {
+        map = OrderedSet.create();
+      }, 'Use of @ember/OrderedSet is deprecated. Please use native `Map` instead', { id: 'ember-map-deprecation', until: '3.5.0' });
     }
 
     ['@test add returns the set'](assert) {

diff --git a/packages/ember-metal/tests/is_empty_test.js b/packages/ember-metal/tests/is_empty_test.js
@@ -36,10 +36,12 @@ moduleFor(
     }
 
     ['@test isEmpty Ember.OrderedSet'](assert) {
-      let orderedSet = new OrderedSet();
-      assert.equal(true, isEmpty(orderedSet), 'Empty ordered set is empty');
-      orderedSet.add('foo');
-      assert.equal(false, isEmpty(orderedSet), 'Ordered set is not empty');
+      expectDeprecation(() => {
+        let orderedSet = new OrderedSet();
+        assert.equal(true, isEmpty(orderedSet), 'Empty ordered set is empty');
+        orderedSet.add('foo');
+        assert.equal(false, isEmpty(orderedSet), 'Ordered set is not empty');
+      }, 'Use of @ember/OrderedSet is deprecated. Please use native `Map` instead', { id: 'ember-map-deprecation', until: '3.5.0' });
     }
   }
 );