Merge pull request #14528 from emberjs/fix-leak-2.8

[BUGFIX release] unregister views from viewRegistry (lts-2-8)
emberjs · Oct 27, 2016 · dd1aa0b · dd1aa0b
2 parents 943910b + 7467350
commit dd1aa0b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/ember-glimmer/lib/renderer.js b/packages/ember-glimmer/lib/renderer.js
@@ -223,7 +223,7 @@ class Renderer {
   }
 
   _unregister(view) {
-    delete this._viewRegistry[this.elementId];
+    delete this._viewRegistry[view.elementId];
   }
 }
 

diff --git a/packages/ember-htmlbars/lib/renderer.js b/packages/ember-htmlbars/lib/renderer.js
@@ -255,12 +255,12 @@ Renderer.prototype.didDestroyElement = function (view) {
 
 
 Renderer.prototype._register = function Renderer_register(view) {
-  assert('Attempted to register a view with an id already in use: ' + view.elementId, !this._viewRegistry[this.elementId]);
+  assert('Attempted to register a view with an id already in use: ' + view.elementId, !this._viewRegistry[view.elementId]);
   this._viewRegistry[view.elementId] = view;
 };
 
 Renderer.prototype._unregister = function Renderer_unregister(view) {
-  delete this._viewRegistry[this.elementId];
+  delete this._viewRegistry[view.elementId];
 };
 
 export const InertRenderer = {
-Original file line number
+Diff line change
@@ Expand Up / @@ -223,7 +223,7 @@ class Renderer { @@
       }
       _unregister(view) {
-        delete this._viewRegistry[this.elementId];
+        delete this._viewRegistry[view.elementId];
       }
     }
@@ Expand Down @@