Merge pull request #11279 from rwjblue/deprecate-each-in

[BUGFIX beta] Deprecate `{{each foo in bar}}`.
emberjs · May 26, 2015 · cc83251 · cc83251
2 parents 1081607 + 6d6576a
commit cc83251
Show file tree

Hide file tree

Showing 11 changed files with 104 additions and 95 deletions.
diff --git a/packages/ember-htmlbars/tests/compat/make_bound_helper_test.js b/packages/ember-htmlbars/tests/compat/make_bound_helper_test.js
@@ -484,7 +484,7 @@ QUnit.test("bound helpers can handle nulls in array (with primitives) [DEPRECATE
     controller: EmberObject.create({
       things: A([null, 0, undefined, false, "OMG"])
     }),
-    template: compile("{{#each things}}{{this}}|{{reverse this}} {{/each}}{{#each thing in things}}{{thing}}|{{reverse thing}} {{/each}}")
+    template: compile("{{#each things}}{{this}}|{{reverse this}} {{/each}}{{#each things as |thing|}}{{thing}}|{{reverse thing}} {{/each}}")
   });
 
   expectDeprecation(function() {
@@ -512,7 +512,7 @@ QUnit.test("bound helpers can handle nulls in array (with objects)", function()
     controller: EmberObject.create({
       things: A([null, { foo: 5 }])
     }),
-    template: compile("{{#each things}}{{foo}}|{{print-foo this}} {{/each}}{{#each thing in things}}{{thing.foo}}|{{print-foo thing}} {{/each}}")
+    template: compile("{{#each things}}{{foo}}|{{print-foo this}} {{/each}}{{#each things as |thing|}}{{thing.foo}}|{{print-foo thing}} {{/each}}")
   });
 
   expectDeprecation(function() {