refactor

emberjs · Feb 2, 2018 · c9f615f · c9f615f
1 parent 2e3257b
commit c9f615f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/broccoli/version.js b/broccoli/version.js
@@ -27,11 +27,9 @@ module.exports.VERSION = (() => {
   // * the sha for the commit
   let packageVersion = pkg.version;
   let sha = info.sha || '';
-  // * remove illegal non-alphanumeric characters from branch name.
-  if(info.branch !== null && new RegExp(/[^a-zA-Z\d\s-]/).test(info.branch)) {
-    info.branch = info.branch.replace(/[^a-zA-Z\d\s-]/, '-');
-  }
   let suffix = process.env.BUILD_TYPE || info.branch;
+  // * remove illegal non-alphanumeric characters from branch name.
+  suffix = suffix.replace(/[^a-zA-Z\d\s-]/, '-');
   let metadata = sha.slice(0, 8);
 
   return `${packageVersion}${suffix ? '-' + suffix : ''}+${metadata}`;