Merge pull request #15982 from emberjs/fix-chains

Fix issue with unchaining ChainNodes (again)
emberjs · Dec 14, 2017 · c376494 · c376494
2 parents db46888 + ac10de2
commit c376494
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/packages/ember-metal/lib/chains.js b/packages/ember-metal/lib/chains.js
@@ -209,11 +209,8 @@ class ChainNode {
   remove(path) {
     let paths = this._paths;
     if (paths === undefined) { return; }
-
     if (paths[path] > 0) {
       paths[path]--;
-    } else {
-      return;
     }
 
     let key = firstKey(path);

diff --git a/packages/ember-metal/lib/watch_path.js b/packages/ember-metal/lib/watch_path.js
@@ -29,7 +29,7 @@ export function unwatchPath(obj, keyPath, meta) {
 
   if (counter === 1) {
     m.writeWatching(keyPath, 0);
-    m.readableChains().remove(keyPath);
+    m.writableChains(makeChainNode).remove(keyPath);
   } else if (counter > 1) {
     m.writeWatching(keyPath, counter - 1);
   }