Merge pull request #10398 from mixonic/undefined-is-null

[BUGFIX release] undefined and values in bind-attr shoud remove attributes

packages/ember-htmlbars/tests/helpers/bind_attr_test.js

@@ -586,3 +586,29 @@ QUnit.test("asserts for <div data-bar='foo' {{bind-attr data-bar='blah'}}></div>
     runAppend(view);
   }, /You cannot set `data-bar` manually and via `{{bind-attr}}` helper on the same element/);
 });
+
+QUnit.test("src attribute bound to undefined is not present", function() {
+  var template = compile("<img {{bind-attr src=view.undefinedValue}}>");
+
+  view = EmberView.create({
+    template: template,
+    undefinedValue: undefined
+  });
+
+  runAppend(view);
+
+  ok(!view.element.hasAttribute('src'), "src attribute not present");
+});
+
+QUnit.test("src attribute bound to null is not present", function() {
+  var template = compile("<img {{bind-attr src=view.nullValue}}>");
+
+  view = EmberView.create({
+    template: template,
+    nullValue: null
+  });
+
+  runAppend(view);
+
+  ok(!view.element.hasAttribute('src'), "src attribute not present");
+});

packages/ember-views/lib/attr_nodes/legacy_bind.js

@@ -22,7 +22,11 @@ LegacyBindAttrNode.prototype.render = function render(buffer) {
   }
   var value = read(this.attrValue);
 
-  if (this.attrName === 'value' && (value === null || value === undefined)) {
+  if (value === undefined) {
+    value = null;
+  }
+
+  if (this.attrName === 'value' && value === null) {
     value = '';
   }