Skip to content

Commit

Permalink
consume only currentURL on the private router instead of computed ali…
Browse files Browse the repository at this point in the history
…ases
  • Loading branch information
NullVoxPopuli committed Sep 4, 2020
1 parent 8635919 commit 8414135
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/@ember/-internals/routing/lib/services/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,7 @@ export default class RouterService extends Service {
// you'd expect isBarActive to be dirtied when the route changes.
//
// https://github.com/emberjs/ember.js/issues/19004
consumeTag(tagFor(this, 'currentURL'));
consumeTag(tagFor(this, 'currentRouteName'));
consumeTag(tagFor(this._router, 'currentURL'));

// UNSAFE: casting `routeName as string` here encodes the existing
// assumption but may be wrong: `extractRouteArgs` correctly returns it as
Expand Down

0 comments on commit 8414135

Please sign in to comment.