[BUGFIX release] Fixes ArrayProxy content updates

ArrayProxy was not properly updating its own chain tags whenever its
content updated, which caused the regression.

Fixing this caused another issue, since we were updating tags with more
recent state and not properly dirtying those tags. Since those tags were
consumed eagerly, earlier on in the render cycle, there was no way to
dirty the tags when the update occured lazily. So, we had to add a
`CUSTOM_TAG_FOR` to trigger the update _when_ the tag was consumed.

packages/@ember/-internals/glimmer/tests/integration/syntax/each-test.js

@@ -1,6 +1,6 @@
 import { moduleFor, RenderingTestCase, applyMixins, strip, runTask } from 'internal-test-helpers';
 
-import { get, set, notifyPropertyChange, computed } from '@ember/-internals/metal';
+import { get, set, notifyPropertyChange, computed, on } from '@ember/-internals/metal';
 import { A as emberA, ArrayProxy, RSVP } from '@ember/-internals/runtime';
 import { HAS_NATIVE_SYMBOL } from '@ember/-internals/utils';
 
@@ -1108,6 +1108,22 @@ moduleFor(
   }
 );
 
+moduleFor(
+  'Syntax test: {{#each}} with array proxies, content is updated after init',
+  class extends EachTest {
+    createList(items) {
+      let wrapped = emberA(items);
+      let proxy = ArrayProxy.extend({
+        setup: on('init', function() {
+          this.set('content', emberA(wrapped));
+        }),
+      }).create();
+
+      return { list: proxy, delegate: wrapped };
+    }
+  }
+);
+
 moduleFor(
   'Syntax test: {{#each as}} undefined path',
   class extends RenderingTestCase {

packages/@ember/-internals/metal/lib/array_events.ts

@@ -32,8 +32,7 @@ export function arrayContentDidChange<T extends { length: number }>(
   array: T,
   startIdx: number,
   removeAmt: number,
-  addAmt: number,
-  notify = true
+  addAmt: number
 ): T {
   // if no args are passed assume everything changes
   if (startIdx === undefined) {
@@ -51,14 +50,12 @@ export function arrayContentDidChange<T extends { length: number }>(
 
   let meta = peekMeta(array);
 
-  if (notify) {
-    if (addAmt < 0 || removeAmt < 0 || addAmt - removeAmt !== 0) {
-      notifyPropertyChange(array, 'length', meta);
-    }
-
-    notifyPropertyChange(array, '[]', meta);
+  if (addAmt < 0 || removeAmt < 0 || addAmt - removeAmt !== 0) {
+    notifyPropertyChange(array, 'length', meta);
   }
 
+  notifyPropertyChange(array, '[]', meta);
+
   sendEvent(array, '@array:change', [array, startIdx, removeAmt, addAmt]);
 
   let cache = peekCacheFor(array);

packages/@ember/-internals/runtime/lib/system/array_proxy.js

@@ -12,13 +12,12 @@ import {
   replace,
   getChainTagsForKey,
   tagForProperty,
-  arrayContentDidChange,
-  arrayContentWillChange,
+  CUSTOM_TAG_FOR,
 } from '@ember/-internals/metal';
 import EmberObject from './object';
 import { isArray, MutableArray } from '../mixins/array';
 import { assert } from '@ember/debug';
-import { combine, update, validate, value } from '@glimmer/validator';
+import { combine, update, validate, value, tagFor } from '@glimmer/validator';
 
 const ARRAY_OBSERVER_MAPPING = {
   willChange: '_arrangedContentArrayWillChange',
@@ -124,6 +123,16 @@ export default class ArrayProxy extends EmberObject {
     this._removeArrangedContentArrayObserver();
   }
 
+  [CUSTOM_TAG_FOR](key) {
+    if (key === '[]') {
+      // revalidate eagerly if we're being tracked, since we no longer will
+      // be able to later on due to backtracking re-render assertion
+      this._revalidate();
+    }
+
+    return tagFor(this, key);
+  }
+
   /**
     The content array. Must be an object that implements `Array` and/or
     `MutableArray.`
@@ -311,6 +320,12 @@ export default class ArrayProxy extends EmberObject {
 
       this._arrangedContentTag = combine(getChainTagsForKey(this, 'arrangedContent'));
       this._arrangedContentRevision = value(this._arrangedContentTag);
+
+      let arrTag = tagForProperty(this, '[]');
+      let lengthTag = tagForProperty(this, 'length');
+
+      update(arrTag, combine(getChainTagsForKey(this, 'arrangedContent.[]')));
+      update(lengthTag, combine(getChainTagsForKey(this, 'arrangedContent.length')));
     }
   }
 }
@@ -325,14 +340,4 @@ ArrayProxy.reopen(MutableArray, {
     @public
   */
   arrangedContent: alias('content'),
-
-  // Array proxies don't need to notify when they change since their `[]` tag is
-  // already dependent on the `[]` tag of `arrangedContent`
-  arrayContentWillChange(startIdx, removeAmt, addAmt) {
-    return arrayContentWillChange(this, startIdx, removeAmt, addAmt, false);
-  },
-
-  arrayContentDidChange(startIdx, removeAmt, addAmt) {
-    return arrayContentDidChange(this, startIdx, removeAmt, addAmt, false);
-  },
 });