Add expectDeprecation to tests to mark places that will need updating…

… when we remove action

packages/@ember/-internals/glimmer/tests/integration/application/actions-test.js

@@ -14,6 +14,8 @@ moduleFor(
     constructor() {
       setDebugFunction('debug', noop);
       super(...arguments);
+
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
     }
 
     teardown() {
@@ -23,7 +25,7 @@ moduleFor(
     ['@test actions in top level template application template target application controller'](
       assert
     ) {
-      assert.expect(1);
+      assert.expect(2);
 
       this.add(
         'controller:application',
@@ -47,7 +49,7 @@ moduleFor(
     }
 
     ['@test actions in nested outlet template target their controller'](assert) {
-      assert.expect(1);
+      assert.expect(2);
 
       this.add(
         'controller:application',

packages/@ember/-internals/glimmer/tests/integration/components/contextual-components-test.js

@@ -757,6 +757,8 @@ moduleFor(
     }
 
     ['@test renders with dot path and updates attributes'](assert) {
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
+
       this.registerComponent('my-nested-component', {
         ComponentClass: Component.extend({
           didReceiveAttrs() {
@@ -839,6 +841,8 @@ moduleFor(
     ['@test parameters in a contextual component are mutable when value is a param'](assert) {
       // This checks that a `(mut)` is added to parameters and attributes to
       // contextual components when it is a param.
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
 
       this.registerComponent('change-button', {
         ComponentClass: Component.extend().reopenClass({
@@ -889,6 +893,7 @@ moduleFor(
     }
 
     ['@test GH#13494 tagless blockless component with property binding'](assert) {
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
       this.registerComponent('outer-component', {
         ComponentClass: Component.extend({
           message: 'hello',
@@ -1442,6 +1447,8 @@ class MutableParamTestGenerator {
   generate({ title, setup }) {
     return {
       [`@test parameters in a contextual component are mutable when value is a ${title}`](assert) {
+        expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
+        expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
         this.registerComponent('change-button', {
           ComponentClass: Component.extend().reopenClass({
             positionalParams: ['val'],

packages/@ember/-internals/glimmer/tests/integration/components/curly-components-test.js

@@ -1428,6 +1428,8 @@ moduleFor(
     ) {
       let componentInstance = null;
 
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       this.registerComponent('non-block', {
         ComponentClass: Component.extend({
           counter: computed({
@@ -3149,6 +3151,8 @@ moduleFor(
     ['@test returning `true` from an action does not bubble if `target` is not specified (GH#14275)'](
       assert
     ) {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       this.registerComponent('display-toggle', {
         ComponentClass: Component.extend({
           actions: {
@@ -3174,7 +3178,9 @@ moduleFor(
     }
 
     ['@test returning `true` from an action bubbles to the `target` if specified'](assert) {
-      assert.expect(4);
+      assert.expect(5);
+
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
 
       this.registerComponent('display-toggle', {
         ComponentClass: Component.extend({

packages/@ember/-internals/glimmer/tests/integration/components/dynamic-components-test.js

@@ -449,6 +449,8 @@ moduleFor(
         }),
       });
 
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
+
       let actionTriggered = 0;
       this.registerComponent('outer-component', {
         template:

packages/@ember/-internals/glimmer/tests/integration/components/input-angle-test.js

@@ -283,7 +283,8 @@ moduleFor(
     ['@test sends an action with `<Input @enter={{action "foo"}} />` when <enter> is pressed'](
       assert
     ) {
-      assert.expect(2);
+      assert.expect(3);
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
 
       this.render(`<Input @enter={{action 'foo'}} />`, {
         actions: {
@@ -300,7 +301,8 @@ moduleFor(
     }
 
     ['@test sends `insert-newline` when <enter> is pressed'](assert) {
-      assert.expect(2);
+      assert.expect(3);
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
 
       this.render(`<Input @insert-newline={{action 'foo'}} />`, {
         actions: {
@@ -319,7 +321,8 @@ moduleFor(
     ['@test sends an action with `<Input @escape-press={{action "foo"}} />` when <escape> is pressed'](
       assert
     ) {
-      assert.expect(2);
+      assert.expect(3);
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
 
       this.render(`<Input @escape-press={{action 'foo'}} />`, {
         actions: {

packages/@ember/-internals/glimmer/tests/integration/components/input-curly-test.js

@@ -152,7 +152,8 @@ moduleFor(
     ['@test sends an action with `{{input enter=(action "foo")}}` when <enter> is pressed'](
       assert
     ) {
-      assert.expect(2);
+      assert.expect(3);
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
 
       this.render(`{{input enter=(action 'foo')}}`, {
         actions: {
@@ -169,7 +170,8 @@ moduleFor(
     }
 
     ['@test sends `insert-newline` when <enter> is pressed'](assert) {
-      assert.expect(2);
+      assert.expect(3);
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
 
       this.render(`{{input insert-newline=(action 'foo')}}`, {
         actions: {
@@ -188,7 +190,8 @@ moduleFor(
     ['@test sends an action with `{{input escape-press=(action "foo")}}` when <escape> is pressed'](
       assert
     ) {
-      assert.expect(2);
+      assert.expect(3);
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
 
       this.render(`{{input escape-press=(action 'foo')}}`, {
         actions: {

packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-angle-test.js

@@ -1027,6 +1027,7 @@ moduleFor(
     }
 
     async ['@test it defaults to bubbling'](assert) {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
       this.addTemplate(
         'about',
         `

packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-curly-test.js

@@ -1097,6 +1097,8 @@ moduleFor(
     }
 
     async ['@test it defaults to bubbling'](assert) {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       this.addTemplate(
         'about',
         `

packages/@ember/-internals/glimmer/tests/integration/components/tracked-test.js

@@ -136,6 +136,8 @@ moduleFor(
     }
 
     '@test tracked properties that are uninitialized do not throw an error'() {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let CountComponent = Component.extend({
         count: tracked(),
 
@@ -162,6 +164,8 @@ moduleFor(
     }
 
     '@test tracked properties rerender when updated'() {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let CountComponent = Component.extend({
         count: tracked({ value: 0 }),
 
@@ -185,6 +189,8 @@ moduleFor(
     }
 
     '@test tracked properties rerender when updated outside of a runloop'(assert) {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let done = assert.async();
 
       let CountComponent = Component.extend({
@@ -216,6 +222,8 @@ moduleFor(
     }
 
     '@test nested tracked properties rerender when updated'() {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let Counter = EmberObject.extend({
         count: tracked({ value: 0 }),
       });
@@ -243,6 +251,8 @@ moduleFor(
     }
 
     '@test array properties rerender when updated'() {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let NumListComponent = Component.extend({
         numbers: tracked({ initializer: () => A([1, 2, 3]) }),
 
@@ -270,6 +280,8 @@ moduleFor(
     }
 
     '@test getters update when dependent properties are invalidated'() {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let CountComponent = Component.extend({
         count: tracked({ value: 0 }),
 
@@ -299,6 +311,8 @@ moduleFor(
     }
 
     '@test getters update when dependent computeds are invalidated'() {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let CountComponent = Component.extend({
         _count: 0,
 
@@ -340,6 +354,8 @@ moduleFor(
     }
 
     '@test nested getters update when dependent properties are invalidated'() {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let Counter = EmberObject.extend({
         count: tracked({ value: 0 }),
 
@@ -373,6 +389,8 @@ moduleFor(
     }
 
     '@test tracked object passed down through components updates correctly'(assert) {
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
+
       let Person = EmberObject.extend({
         first: tracked({ value: 'Rob' }),
         last: tracked({ value: 'Jackson' }),
@@ -423,6 +441,8 @@ moduleFor(
     }
 
     '@test yielded getters update correctly'() {
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
+
       let PersonComponent = Component.extend({
         first: tracked({ value: 'Rob' }),
         last: tracked({ value: 'Jackson' }),
@@ -462,6 +482,8 @@ moduleFor(
     }
 
     '@test yielded nested getters update correctly'() {
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
+
       let Person = EmberObject.extend({
         first: tracked({ value: 'Rob' }),
         last: tracked({ value: 'Jackson' }),
@@ -587,6 +609,8 @@ moduleFor(
     '@test downstream property changes do not invalidate upstream component getters/arguments'(
       assert
     ) {
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       let outerRenderCount = 0;
       let innerRenderCount = 0;
 

packages/@ember/-internals/glimmer/tests/integration/components/utils-test.js

@@ -49,6 +49,8 @@ moduleFor(
         },
       });
 
+      expectDeprecation(/Usage of the `\{\{action\}\}` modifier is deprecated./);
+
       this.add('controller:application', ToggleController);
 
       this.addTemplate(

packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js

@@ -134,6 +134,8 @@ moduleFor(
     }
 
     ['@test case insensitive events'](assert) {
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
+
       let receivedEvent;
 
       this.registerComponent('x-bar', {
@@ -153,6 +155,7 @@ moduleFor(
     }
 
     ['@test case sensitive events'](assert) {
+      expectDeprecation(/Usage of the `\(action\)` helper is deprecated./);
       let receivedEvent;
 
       this.registerComponent('x-bar', {