-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scenario: ember-canary failing #866
Comments
stefanpenner
referenced
this issue
in emberjs/ember.js
Jul 29, 2021
We currently export a few private functions from `@ember/runloop` for packages like `@ember/test-helpers`. These functions are not public API, but need to be accessible for these core packages. Previously they were exposed on the private APIs of the global `run`, but now that we're getting rid of the the modules transform these are now exposed directly, so underscoring them should help make users aware that they are not meant for public consumption.
stefanpenner
added a commit
to emberjs/ember.js
that referenced
this issue
Jul 29, 2021
Ember-qunit needs access to backburner in a backwards/forward compatible way
Actually it works really nicely now 😸 import { _backburner } from '@ember/runloop'; This syntax works on all supported Ember versions (going back a long way) as long as the addon or app in question has a new enough ember-cli-babel version (at least [email protected]). |
@rwjblue yup thats great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the ember-canary scenario is failing due to ember-source removing
import { backburner } from '@ember/runloop';
in-favor ofimport { _backburner } from '@ember/runloop';
.I'm not sure if there is sufficient dynamism here to have a backwards & forwards compatibility here. It may need
@ember/runloop
to reconsider thebackburner
->_backburner
transition.The change in question
The text was updated successfully, but these errors were encountered: