[CHORE tests] Added explicit -json-api serializer registration in tests #6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicEric
reviewed
Aug 23, 2019
packages/-ember-data/tests/integration/adapter/find-all-test.js
Outdated
Show resolved
Hide resolved
HeroicEric
reviewed
Aug 23, 2019
packages/-ember-data/tests/integration/client-id-generation-test.js
Outdated
Show resolved
Hide resolved
Part of emberjs#6166 Co-Authored-By: Eric Kelly <[email protected]>
yohanmishkin
force-pushed
the
chore/eliminate-json-serializer-usage
branch
from
7256473 to
b5996fc
Compare
runspired
added
the
🌲 Project Trim 🌲
runspired
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this PR is to mirror #6368 but for -json-api fallback behavior.
RFC-522 will deprecate the -json-api serializer and usage of the adapter.defaultSerializer fallback which for the JSONAPIAdapter is set to -json-api. This PR entirely removes our reliance on this fallback from our own test suite.
Part of #6166
Co-Authored-By: Eric Kelly @HeroicEric