Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reversed args in Ember.Observer #3553

Merged
merged 1 commit into from
Jul 17, 2015
Merged

Reversed args in Ember.Observer #3553

merged 1 commit into from
Jul 17, 2015

Conversation

BBLN
Copy link
Contributor

@BBLN BBLN commented Jul 17, 2015

@rwjblue
Copy link
Member

rwjblue commented Jul 17, 2015

👍

bmac added a commit that referenced this pull request Jul 17, 2015
@bmac
Merge pull request #3553 from BBLN/patch-1
3fef569 
Reversed args in Ember.Observer
@bmac bmac merged commit 3fef569 into emberjs:master Jul 17, 2015
@jcope2013
Copy link
Contributor

can this be marked for release branch as there is now a deprecation warning in console when using ember 1.13.5

Passing the dependentKeys after the callback function in Ember.observer is deprecated. Ensure the callback function is the last argument.

emberjs/ember.js#11778
https://github.com/emberjs/ember.js/releases/tag/v1.13.5

@igorT igorT mentioned this pull request Jul 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BBLN @rwjblue @jcope2013 @bmac