Support indents and folding

[yads]

• added indents.scm and folds.scm queries

[alexlafroscia]

Hey, thanks for the PR!

Is there some way to add tests for these new features, the way that the highlighting has tests?

[yads]

I honestly have no idea how to do that. I looked at the tests directory and can't make heads or tails of what's going on. Is there somewhere you can point me to get more info?

[yads]

Did some more digging and near as I can tell only parsing and highlights tests are supported by tree-sitter test. https://tree-sitter.github.io/tree-sitter/creating-parsers#command-test. On the plus side I'll add a locals.scm query as well.

[lougreenwood]

🎉

[NullVoxPopuli]

somehow I already have these in my local install? is this PR needed?

❯ echo $PWD
/home/nvp/.local/share/nvim/site/pack/packer/start/nvim-treesitter/queries/glimmer

❯ cat folds.scm indents.scm locals.scm 
───────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: folds.scm
───────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ [
   2   │  (element_node (element_node_start))
   3   │  (block_statement)
   4   │ ] @fold
───────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
───────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: indents.scm
───────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ [
   2   │   (element_node (element_node_start))
   3   │   (element_node_void)
   4   │   (block_statement (block_statement_start))
   5   │   (mustache_statement)
   6   │ ] @indent.begin
   7   │ 
   8   │ (element_node (element_node_end  [">"] @indent.end))
   9   │ (element_node_void "/>" @indent.end)
  10   │ [
  11   │  ">"
  12   │  "/>"
  13   │  "</"
  14   │  "{{/"
  15   │  "}}"
  16   │ ] @indent.branch
  17   │ 
  18   │ (mustache_statement
  19   │   (helper_invocation helper: (identifier) @_identifier (#eq? @_identifier "else"))
  20   │   ) @indent.branch
  21   │ (mustache_statement ((identifier) @_identifier (#eq? @_identifier "else"))) @indent.branch
  22   │ (comment_statement) @indent.ignore
───────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
───────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: locals.scm
───────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ [
   2   │  (element_node)
   3   │  (block_statement)
   4   │ ] @scope
   5   │ 
   6   │ (identifier) @reference
   7   │ (block_params (identifier) @definition.var)
───────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────

[yads]

So technically it isn't because I submitted these changes to treesitter directly nvim-treesitter/nvim-treesitter@0ae4942 However, it would be good to have these merged into the main repo for glimmer imo.

[NullVoxPopuli]

I'm a newb and I don't know anything, so what's the advantage of having files here vs there? <3

[yads]

No idea, but that's how all the treesitter projects seem to be structured.

…

On Thu, Oct 26, 2023 at 12:37 PM NullVoxPopuli ***@***.***> wrote: I'm a newb and I don't know anything, so what's the advantage of having files here vs there? — Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEAYZZ4VHKX6ZHIQD7QSLTYBKUYNAVCNFSM6AAAAAAY3CB562VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBRGY3DGOBVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

--

-Vadim Kazakov

[NullVoxPopuli]

@alexlafroscia can we merge and release?

[NullVoxPopuli]

hm.. this was not intended to be closed.

I tried rebasing the branch, and I guess something went wrong?