Improve explanation of passing actions (#162) #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjayjpg
reviewed
Oct 2, 2018
| ```handlebars {data-filename=app/templates/index.hbs} | ||
| {{button-with-confirmation | ||
| text="Click here to unsubscribe." | ||
| onConfirm=(action 'unsubscribe') |
There was a problem hiding this comment.
I think it would be good to update the quotes here in the action helper, too, to also use the double quoted version as the other string expression in the template examples:
(action "unsubscribe")
|
I've updated the formatting of the quotes as instructed ☕️ 😄 |
jayjayjpg
reviewed
Oct 3, 2018
| ``` | ||
|
|
||
| It is important to note that actions can only be passed from a controller or another | ||
| component. They cannot be passed from a route. See [passing an action to the component](/triggering-changes-with-actions/#toc_passing-the-action-to-the-component) |
There was a problem hiding this comment.
I just had another look locally and this already looks great! One more thing I noticed is, that the link here doesn't point to the correct page, yet:
Can you check what is missing for the link? I assume there are other relative links in the guides source which you can use as a reference, too.
Parrryy
force-pushed
the
teach-passing-actions
branch
2 times, most recently
from
1347823 to
f795ef1
Compare
Parrryy
force-pushed
the
teach-passing-actions
branch
from
f795ef1 to
2d9147f
Compare
This was referenced Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft for #162