For Ember Times No. 96: Add Writeup for Milestones + Ember Paris Contributor Workshop #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjayjpg
force-pushed
the
embertimes-jj2
branch
from
bfe85dc to
9d432e5
Compare
jayjayjpg
force-pushed
the
embertimes-jj2
branch
from
9d432e5 to
4940523
Compare
jayjayjpg
changed the title
amyrlam
reviewed
May 1, 2019
amyrlam
reviewed
May 1, 2019
ijlee2
reviewed
May 1, 2019
ijlee2
reviewed
May 1, 2019
ijlee2
reviewed
May 1, 2019
ijlee2
reviewed
May 1, 2019
|
Awesome writing in both articles! |
Co-Authored-By: jessica-jordan <[email protected]>
Co-Authored-By: jessica-jordan <[email protected]>
Co-Authored-By: jessica-jordan <[email protected]>
Co-Authored-By: jessica-jordan <[email protected]>
MinThaMie
reviewed
May 1, 2019
| <add blurb and emoji to "SOME-INTRO-HERE"> | ||
| Last week's **contributor workshop**, organised by the folks over at the [EmberJS Paris meetup](https://twitter.com/EmberJSParis), was a **real success**: with new changes to Ember CLI, improvements to Ember addons and even a brand-new RFC written, the Ember community gave back to the project, with some of the work even being made by first-time contributors! 🙌 | ||
|
|
||
| Already feeling inspired to participate in or initiate your own **Ember contributor workshop**? Be sure to check out [these helpful resources to help you get you started](https://github.com/ember-learn/emberjs-contributors-workshop). And don't forget to check back on [#dev-ember-learning Discord channel](https://discordapp.com/invite/emberjs) and the [Ember Help Wanted app](https://help-wanted.emberjs.com/) to find something neat to work on. Codage heurex! 💻❤️ |
There was a problem hiding this comment.
I would remove the help after the to, helpful resources in itself are meant to help :)
There was a problem hiding this comment.
Agreed, I'll update that one 👍
|
|
||
| Managing **concurrency in your app** can be hard (at least, until you start using [ember-concurrency](http://ember-concurrency.com) ✨). Managing **concurrency in your tests** can be even harder. | ||
| But **managing concurrent behaviour** in your **tests** can be even harder. | ||
|
|
There was a problem hiding this comment.
Maybe make this the hardest or something other than can be even harder because you already use that before.
|
Thank you for the review @MinThaMie, I updated the writeup accordingly ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Related Issue(s)
Sources