Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Apollo Client v3 #355

Merged
merged 5 commits into from
Aug 2, 2020
Merged

Conversation

benkingcode
Copy link
Contributor

Hello! I'm spinning up a new project and ember-apollo-client doesn't work with the just-released Apollo Client v3. Very minimal changes should be necessary to update it.

@josemarluedke josemarluedke self-assigned this Jul 21, 2020
@josemarluedke
Copy link
Member

Hi @dbbk! First, thank you for working on this.

A few things are still missing in this PR. First, tests must pass. There are several references in the codebase to the following packages.

  • apollo-cache-inmemory
  • apollo-link-http
  • apollo-client

Please also update the readme section around dependencies, plus the recommended packages.

Additionally, there is a warning about a missing peer dependency:

warning " > @apollo/[email protected]" has unmet peer dependency "subscriptions-transport-ws@^0.9.0".

Is this dependency not needed? Or was just not added?

Looking forward to moving this along.

@benkingcode
Copy link
Contributor Author

Cool, I've fixed a few of the imports. I think subscriptions-transport-ws is optional, it would only be needed if a consuming app uses subscriptions.

The main thing still left to do is that IntrospectionFragmentMatcher appears to have been removed from v3, so the tests will need re-working.

@josemarluedke josemarluedke changed the base branch from master to feat/v3 August 2, 2020 14:59
@josemarluedke josemarluedke merged commit d215444 into ember-graphql:feat/v3 Aug 2, 2020
@josemarluedke
Copy link
Member

@dbbk Thank you for working on this. I have merged it into a feature branch where I will pick up the remaining changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants