Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support change for Ember 3.24 LinkTo refactor #740

Closed
chriskrycho opened this issue Dec 22, 2020 · 5 comments · Fixed by #742
Closed

Support change for Ember 3.24 LinkTo refactor #740

chriskrycho opened this issue Dec 22, 2020 · 5 comments · Fixed by #742

Comments

@chriskrycho
Copy link
Contributor

emberjs/ember.js#19223 made a breaking change to the private implementation of <LinkTo> which Engines relies on. This breaks any existing user of Engines which upgrade to Ember 3.24. We need to add a conditional handling for gte("3.24.0") to not apply the monkey-patch.
@chriskrycho
Copy link
Contributor Author

cc. @rwjblue @villander

@chriskrycho chriskrycho mentioned this issue Dec 22, 2020
Merged
@chriskrycho
Copy link
Contributor Author

With Ember 3.24 out, this is now blocking any app from upgrading which depends on Engines!

@fkm-adfinis
Copy link

It also breaks the pipelines before upgrading because of ember:try.

rwjblue added a commit that referenced this issue Jan 13, 2021
@rwjblue
Disable CI for Ember 3.24+ due to #740.
f32392f 
This is so that we can ensure that CI is passing for the TravisCI -> GH
Actions migration (unrelated to the 3.24+ issues).
@rwjblue rwjblue mentioned this issue Jan 14, 2021
Merged
@rwjblue
Copy link
Member

rwjblue commented Jan 14, 2021

Fixed in [email protected].

@chriskrycho
Copy link
Contributor Author

Thanks so much, @rwjblue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compatibility with Ember 3.24+ ember-engines/ember-engines
3 participants
@rwjblue @chriskrycho @fkm-adfinis