This repository was archived by the owner on Feb 23, 2020. It is now read-only.
pin ember data version to ^3.10.0 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafreeman
force-pushed
the
cfreeman/pin-ember-data-version
branch
from
0ea8bf9 to
ca33b95
Compare
| @@ -34,7 +34,7 @@ | |||
| "ember-cli-sri": "^2.1.1", | |||
| "ember-cli-template-lint": "^1.0.0-beta.1", | |||
| "ember-cli-uglify": "^2.1.0", | |||
| "ember-data": "<%= emberData %>", | |||
| "ember-data": "^3.10.0", | |||
There was a problem hiding this comment.
Instead of hard coding this to ^3.10.0, can it be the latest release? So that way as ember-data continues to release new versions, we don't need to keep updating the blueprint?
There was a problem hiding this comment.
That's actually the behavior we get from the ^ in ^3.10.0, since ^ will resolve to the latest available 3.x version (but not less than 3.10)
| @@ -16,15 +16,12 @@ module.exports = { | |||
| getRepoVersion('ember-cli', 'ember-cli'), | |||
| getRepoVersion('emberjs', 'data'), | |||
There was a problem hiding this comment.
I think you need to remove this line?
cafreeman
force-pushed
the
cfreeman/pin-ember-data-version
branch
from
ca33b95 to
ac54265
Compare
NullVoxPopuli
approved these changes
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address an issue (reported here) with Ember Data in the current Octane blueprint where there were some issues because the default usage of
fetchin ember data was still in progress.This work has now been completed here, so we can pin the ember data version to the latest stable release 💪