This repository was archived by the owner on Mar 15, 2023. It is now read-only.
[Bugfix] ensure global does not leak #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
fix-leak
branch
2 times, most recently
from
1679181 to
6bad81e
Compare
|
|
||
| assert.equal(window.Foo, 'blazorz'); | ||
| assert.equal(window.Foo, app); | ||
| }); | ||
|
|
||
| test('it does not set the global unless exportApplicationGlobal is true', function(assert) { | ||
| config.modulePrefix = 'foo'; | ||
| config.exportApplicationGlobal = false; |
There was a problem hiding this comment.
is there already a test that does the opposite exportApplicationGlobal = true; ?
There was a problem hiding this comment.
now we are: 9c12bfe i think thats what you meant
There was a problem hiding this comment.
yeah that was my curiosity, thanks :)
Now the application will remove its global on destruction.
stefanpenner
added a commit
that referenced
this pull request
Jul 20, 2015
[Bugfix] ensure global does not leak
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the application will remove its global on destruction.