[Safe for 2.0] Update initializer blueprints. #4841
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +15,7 @@ module('<%= friendlyTestName %>', { | |||
|
|
|||
| // Replace this with your real tests. | |||
| test('it works', function(assert) { | |||
| initialize(registry, application); | |||
| <%= classifiedModuleName %>Initializer.initialize(application); | |||
There was a problem hiding this comment.
The application is only passed as the first argument in Ember 2.1, but master is tracking 2.0.
|
👍 on fixing the context by invoking the initializer properly, but we cannot change the argument info until master is targeting Ember 2.1. |
nathanhammond
changed the title
|
I've been living in the coal mine for too long... splitting into two PRs, one to wait for 2.1, this one to land. |
…updated to address those changes. See: emberjs/ember.js#10179
nathanhammond
force-pushed
the
initializer-blueprint
branch
from
04a8ae8 to
1339af7
Compare
nathanhammond
changed the title
|
same comment as -> #4842 (comment) |
|
@stefanpenner - We should still update them here so that we have an up to date version that gets extracted. |
|
☔ The latest upstream changes (presumably #4920) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing in favor of fixing forward #4920 to address emberjs/ember.js#10179. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initializer API has changed as of 2.X, the blueprints need to be updated to address those changes. See also: emberjs/ember.js#10179