Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): add support for stripping decorators #25

Merged

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Oct 4, 2017

Adds support for stripping decorators, which will be useful now that the ES Class RFC is merged. This will allow us to write decorators that can do runtime checks/transformations of classes, methods, and fields such as type checking, but can then be stripped out of production builds.

@mmun
Copy link
Member

mmun commented Oct 4, 2017

This looks good to me 👍

@rwjblue rwjblue requested a review from layershifter October 5, 2017 00:47
Copy link
Collaborator

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some styling changes, LGTM. I'm not familar with decorators, but looks correct.

Thanks again 👍

@layershifter layershifter changed the title feat(decorators): Adds support for stripping decorators feat(plugin): add support for stripping decorators Oct 5, 2017
@layershifter layershifter merged commit fe9f4ba into ember-cli:master Oct 5, 2017
@layershifter
Copy link
Collaborator

Released in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants