Skip to content

Migrate to assertEqual #18488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

Conversation

emmanuel-ferdman
Copy link
Contributor

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

Change Summary

This small PR migrates from unittest.assertEquals to unittest.assertEqual which is deprecated from Python2.7:

DeprecationWarning: Please use assertEqual instead.

Sorry, something went wrong.

Signed-off-by: Emmanuel Ferdman <[email protected]>
@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner May 29, 2025 13:00
@CLAassistant
Copy link

CLAassistant commented May 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@reivilibre reivilibre self-requested a review June 6, 2025 11:14
@reivilibre reivilibre enabled auto-merge (squash) June 6, 2025 11:14
@reivilibre reivilibre disabled auto-merge June 6, 2025 15:13
@reivilibre reivilibre merged commit 6521406 into element-hq:develop Jun 6, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants