-
Notifications
You must be signed in to change notification settings - Fork 345
Update pyproject.toml
in line with Poetry 2.x
#18432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
pyproject.toml
according to Poetry documentationpyproject.toml
in line with Poetry 2.x
a1a8610
to
7564524
Compare
A `poetry-core` version >=2.0 is required to understand the latest changes to `pyproject.toml`.
d276294
to
830e54d
Compare
To align with element-hq/synapse#18432
If we're only defining static classifiers, then they should live under `project` instead of `tool.poetry`.
@@ -1,3 +1,45 @@ | |||
[project] | |||
name = "matrix-synapse" | |||
version = "1.129.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version
needs to be bumped
dynamic = [ | ||
# TODO: Transition our `tool.poetry.dependencies` section to | ||
# `project.dependencies`. | ||
"dependencies", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand the comment but can you explain the reasoning behind dynamic = ["dependencies"]
itself. I'm not following exactly why
homepage = "https://github.com/element-hq/synapse" | ||
repository = "https://github.com/element-hq/synapse" | ||
documentation = "https://element-hq.github.io/synapse/latest" | ||
"Bug Tracker" = "https://github.com/element-hq/synapse/issues" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Bug Tracker"
idiomatic? Big projects doing this? Something that PyPI supports?
Is it really necessary over when we already have the homepage
and repository
links and issues are a click away
@@ -315,7 +330,7 @@ all = [ | |||
# - systemd: this is a system-based requirement | |||
] | |||
|
|||
[tool.poetry.dev-dependencies] | |||
[tool.poetry.group.dev.dependencies] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I see this deprecation warning all the time
$ SYNAPSE_TEST_LOG_LEVEL=INFO poetry run trial tests.media.test_html_preview
The "poetry.dev-dependencies" section is deprecated and will be removed in a future version. Use "poetry.group.dev.dependencies" instead.
...
Our
pyproject.toml
was generating a number of errors in our CI. This appears to be a follow-on from #18251. I noticed this when debugging an unrelated PR.Click to see error log
Original GHA workflow run logs: https://github.com/element-hq/synapse/actions/runs/14931031372/job/41947086455?pr=18417#step:3:67
This PR fixes those issues by updating our
pyproject.toml
file to make use of the new keys defined by PEP 621.Paired with matrix-org/sytest#1403 which updates
poetry-core
to 2.1.3 in Sytest.Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)