Prevent various room subscription task from blocking opening rooms #3873
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this came from having seen the opening room modal show up too often which was caused by `isEncrypted` being block_on on the rust side and sometimes making network requests - we aggreed that the `block_on`s should go, which is handled in matrix-org/matrix-rust-sdk#4756 and matrix-org/matrix-rust-sdk#4757
Velin92
approved these changes
Mar 5, 2025
Hywan
reviewed
Mar 5, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3873 +/- ##
===========================================
+ Coverage 79.12% 79.15% +0.03%
===========================================
Files 793 793
Lines 70434 70434
===========================================
+ Hits 55728 55750 +22
+ Misses 14706 14684 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isEncryptedbeing block_on on the rust side and sometimes making network requestsblock_ons should go, which is handled in fix(ffi):Room::is_encryptedis now async matrix-org/matrix-rust-sdk#4756 and chore(ffi): Remove uselessblock_onmatrix-org/matrix-rust-sdk#4757