Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): error if system check fails #3852

Merged
merged 1 commit into from
Feb 15, 2025
Merged

fix(cli): error if system check fails #3852

merged 1 commit into from
Feb 15, 2025

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Feb 14, 2025 •
edited
Loading

Fixes #3849

> npm install -g [email protected]
npm warn deprecated [email protected]: It is recommended to install Yarn using the native installation method for your environment. See https://yarnpkg.com/en/docs/install

changed 1 package in 848ms

> yarn start
yarn start v0.28.4
$ electron-forge start
❯ Checking your system
  ✖ Checking node version
  ✖ Incompatible version of yarn detected: "0.28.4" must be in range >= 1.0.0
error Command failed with exit code 1.

@erickzhao erickzhao requested a review from a team as a code owner February 14, 2025 01:32
@erickzhao erickzhao added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 18b3db1 Feb 15, 2025
14 checks passed
@erickzhao erickzhao deleted the cli/error-if-system-check-fails branch February 15, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check-system doesn't fail on CLI
3 participants
@erickzhao @VerteDinde @BlackHole1