Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): clean up output #3851

Merged
merged 3 commits into from
Feb 13, 2025
Merged

fix(cli): clean up output #3851

merged 3 commits into from
Feb 13, 2025

Conversation

erickzhao
Copy link
Member

This PR improves our CLI --help output usage and refactors the executable command code.

  • Moves the execution of @electron-forge/core APIs to within the commander action where possible (avoids an async IIFE).
  • Cleans up prose and default values for all commands and options.
  • Changes function args for workingDir because the first arg was always process.cwd() in all callsites.
  • Adds test coverage for workingDir.

@erickzhao erickzhao requested a review from a team as a code owner February 13, 2025 00:52
BlackHole1
BlackHole1 reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But have a nit

@erickzhao erickzhao added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 9f31a24 Feb 13, 2025
12 checks passed
@erickzhao erickzhao deleted the cli-executable-cleanup branch February 13, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickzhao @dsanders11 @BlackHole1