Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(cli): only check system on commands #3843

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

erickzhao
Copy link
Member

Instead of running the system check on every electron-forge CLI run, this PR instead skips it by default if no command is run or if the --help option is triggered on a command.

This is inspired by @CodeWitchBella's comment in #3313, which I'm reading almost 2 years late (sorry 🙇).

Sidenote: I'd argue that this check should not run at all for things like --version or --help to make debugging a bit less painful. Also, the message references git and node.js when the issue is with yarn version.

@erickzhao erickzhao requested a review from a team as a code owner February 8, 2025 07:54
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzhao erickzhao added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit ec9ba21 Feb 10, 2025
13 checks passed
@erickzhao erickzhao deleted the cli/only-check-system-on-command branch February 10, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants