Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output.split is not a function #410

Closed
zeke opened this issue Jan 13, 2018 · 1 comment · Fixed by #423
Closed

output.split is not a function #410

zeke opened this issue Jan 13, 2018 · 1 comment · Fixed by #423
Assignees

Comments

@zeke
Copy link

zeke commented Jan 13, 2018

$ electron-forge --version
✔ Checking your system
4.2.0


$ electron-forge install hypermodules/hyperamp
✔ Checking your system
✔ Searching for Releases
Found latest release: v0.5.8
? Multiple potential assets found, please choose one from the list below: Hyperamp-0.5.8.dmg
✖ Installing Application

An unhandled error has occurred inside Forge:
output.split is not a function
TypeError: output.split is not a function
    at /usr/local/lib/node_modules/electron-forge/dist/util/hdiutil.js:29:27
    at Generator.next (<anonymous>)
    at Generator.tryCatcher (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/util.js:16:23)
    at PromiseSpawn._promiseFulfilled (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/generators.js:97:49)
    at Promise._settlePromise (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/promise.js:574:26)
    at Promise._settlePromise0 (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/promise.js:693:18)
    at Async._drainQueue (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:781:20)
    at tryOnImmediate (timers.js:743:5)
    at processImmediate [as _immediateCallback] (timers.js:714:5)
@zeke
Copy link
Author

zeke commented Jan 22, 2018

Saw it break again for a different app's DMG, but worked for its ZIP:

$ electron-forge install 0x00A/scratches
✔ Checking your system
✔ Searching for Releases
Found latest release: 0.0.5
? Multiple potential assets found, please choose one from the list below: Scratches-0.0.5.dmg
Downloading 0x00A-scratches-0.0.5-Scratches-0.0.5.dmg
[============================================>] 100.0% of 50.36 MB (2.24 MB/s)
✖ Installing Application

An unhandled error has occurred inside Forge:
output.split is not a function
TypeError: output.split is not a function
    at /usr/local/lib/node_modules/electron-forge/dist/util/hdiutil.js:29:27
    at Generator.next (<anonymous>)
    at Generator.tryCatcher (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/util.js:16:23)
    at PromiseSpawn._promiseFulfilled (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/generators.js:97:49)
    at Promise._settlePromise (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/promise.js:574:26)
    at Promise._settlePromise0 (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/promise.js:693:18)
    at Async._drainQueue (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues (/usr/local/lib/node_modules/electron-forge/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:781:20)
    at tryOnImmediate (timers.js:743:5)
    at processImmediate [as _immediateCallback] (timers.js:714:5)

~/git/electron/electron-security-review blog-post 31s
$ electron-forge install 0x00A/scratches
✔ Checking your system
✔ Searching for Releases
Found latest release: 0.0.5
? Multiple potential assets found, please choose one from the list below: Scratches-0.0.5-mac.zip
Downloading 0x00A-scratches-0.0.5-Scratches-0.0.5-mac.zip
[============================================>] 100.0% of 48.6 MB (2.18 MB/s)
✔ Installing Application

@zeke zeke added the bug label Jan 22, 2018
malept added a commit that referenced this issue Jan 26, 2018
cross-spawn-promise returns stdout as a buffer.

ISSUES CLOSED: #410
malept added a commit that referenced this issue Jan 27, 2018
cross-spawn-promise returns stdout as a buffer.

ISSUES CLOSED: #410
malept added a commit that referenced this issue Jan 27, 2018
cross-spawn-promise returns stdout as a buffer.

ISSUES CLOSED: #410
@malept malept self-assigned this Jan 28, 2018
@malept malept added the in pr label Jan 28, 2018
malept added a commit that referenced this issue Jan 29, 2018
cross-spawn-promise returns stdout as a buffer.

ISSUES CLOSED: #410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants