-
Notifications
You must be signed in to change notification settings - Fork 37
Fix bump MS Golang bump in 1.23 #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit fixes the Goland bump GH action in the 1.23 branch which is failing due to a missing script.
Setting to draft as there were issues triggering a manual run: https://github.com/elastic/golang-crossbuild/actions/runs/15725774989 ![]()
|
I backported #629 but missed to include this file. Thanks |
AFAIS, the previous github workflow in main is the one to be used, while the one in Let me add the change in this PR so we can test in isolation if things work as expected https://github.com/elastic/golang-crossbuild/actions/runs/15729594319 is now running 🤞
that's expected since it uses the how to test these changes locally? $ gh pr checkout 632
$ GITHUB_TOKEN=$(gh auth token) \
GITHUB_ACTOR=v1v \
BRANCH=fix-microsoft-go-bump-in-1_23 \
GO_MINOR=1.23 \
updatecli apply --config ./.github/updatecli.d/ produced
And that's now something I wanna work so I can fix the existing issues with mixing two bump that are to a certain related to each other. |
we need only main but for testing an old branch we need those versions up-to-date
This commit fixes the Goland bump GH action in the 1.23 branch which is failing due to a missing script.
This was the failure observed: https://github.com/elastic/golang-crossbuild/actions/runs/15723702898/job/44309400069#step:3:349