Skip to content

Fix bump MS Golang bump in 1.23 #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Fix bump MS Golang bump in 1.23 #632

merged 2 commits into from
Jun 25, 2025

Conversation

dliappis
Copy link
Contributor

This commit fixes the Goland bump GH action in the 1.23 branch which is failing due to a missing script.

This was the failure observed: https://github.com/elastic/golang-crossbuild/actions/runs/15723702898/job/44309400069#step:3:349

This commit fixes the Goland bump GH action in the 1.23 branch which
is failing due to a missing script.
@dliappis dliappis self-assigned this Jun 18, 2025
@dliappis dliappis requested a review from a team as a code owner June 18, 2025 06:40
@dliappis
Copy link
Contributor Author

dliappis commented Jun 18, 2025

Setting to draft as there were issues triggering a manual run: https://github.com/elastic/golang-crossbuild/actions/runs/15725774989

image

@dliappis dliappis marked this pull request as draft June 18, 2025 06:43
v1v
v1v previously approved these changes Jun 18, 2025
@v1v
Copy link
Member

v1v commented Jun 18, 2025

I backported #629 but missed to include this file. Thanks

@v1v v1v marked this pull request as ready for review June 18, 2025 09:44
@v1v v1v marked this pull request as draft June 18, 2025 09:45
@v1v
Copy link
Member

v1v commented Jun 18, 2025

Setting to draft as there were issues triggering a manual run: elastic/golang-crossbuild/actions/runs/15725774989

AFAIS, the previous github workflow in main is the one to be used, while the one in 1.23 points to the old version 1.22. We don't backport those GH actions but keep them up-to-date in main.

Let me add the change in this PR so we can test in isolation if things work as expected


https://github.com/elastic/golang-crossbuild/actions/runs/15729594319 is now running 🤞

command stderr output was:
----
/tmp/updatecli/bin/85e65467bf89c2d94fa810c3870bcec2cffb0692ebf098263381494a59442bfe.sh: 1: .github/updatecli.d/bump-go-microsoft-version.sh: not found

that's expected since it uses the 1.23 branch explicitly.

how to test these changes locally?

$ gh pr checkout 632
$ GITHUB_TOKEN=$(gh auth token) \
   GITHUB_ACTOR=v1v \
   BRANCH=fix-microsoft-go-bump-in-1_23 \
   GO_MINOR=1.23 \
   updatecli apply --config ./.github/updatecli.d/

produced

- Bump golang-version to latest version:
	Source:
		✔ [latestGoVersion] Get Latest Go Release
		✔ [minor] Get minor version
	Condition:
		✔ [dockerTag] Is docker image golang:1.23.10 published
		✗ [is-already-updated] Is version '1.23.10' not updated in 'go/Makefile.common'?
	Target:
		- [update-go-makefile.common] 
		- [update-go-version] 
		- [update-go-versions] 


✗ Bump golang-microsoft to latest version:
	Source:
		✔ [golangVersion] Get golang version
		✔ [latestGoVersion] Get Latest Go Release
		✔ [minor] Get minor version
		✔ [securityVersion] Get security version
	Condition:
		✔ [is-security-already-updated] Is security version '-1' not updated in 'go/base/Dockerfile.tmpl'?
	Target:
		✗ [update-go-versions] Update go version 1.23.10-1


Run Summary
===========
Pipeline(s) run:
  * Changed:	0
  * Failed:	1
  * Skipped:	1
  * Succeeded:	0
  * Total:	2

ERROR: ✗ 1 over 2 pipeline failed

And that's now something I wanna work so I can fix the existing issues with mixing two bump that are to a certain related to each other.

we need only main but for testing an old branch we need those versions up-to-date
@v1v v1v marked this pull request as ready for review June 18, 2025 09:55
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 18, 2025
@v1v v1v merged commit 91d96ec into 1.23 Jun 25, 2025
3 of 4 checks passed
@v1v v1v deleted the fix-microsoft-go-bump-in-1_23 branch June 25, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants