Skip to content

Fixing indices create partially #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

l-trotta
Copy link
Contributor

The missing validated tests are either:

  • wrong tests IMO, will provide a fix in the flight recorder
  • new features (bbq_ivf is still very experimental, since even the name could change I don't think it should be added yet)
  • validation bugs

Details:

  • IcuCollationTokenFilter's fields are actually snakeCase and not camel_case -> server code
  • HunspellTokenFilter: locale has two aliases, and if it's set as mandatory as it was before, this means that the generator will generate 3 mandatory fields. For now I'm setting this as optional, but maybe we should support this as a feature?
  • PatternReplaceTokenFilter was missing the flags field -> server code
  • In EdgeNGramTokenizer, token_chars can also be expressed as a csv, so making it a string | enum union
  • RankVectorProperty was missing -> server code
  • FlattenedProperty was missing time_series_dimensions -> server code
  • AggregateMetricDoubleProperty was missing ignore_malformed -> server code
  • GeoPointProperty was missing time_series_metric -> server code
  • Storage in IndexSettings was missing stats_refresh_interval, but I also noticed that in the code and yaml tests there was no trace of the type field, nor the StorageType enum, so maybe we can remove that. -> server code

Copy link
Contributor

Following you can find the validation changes for the APIs you have modified.

API Status Request Response
indices.create 🔴 1184/1235 → 1209/1235 1235/1235
indices.get_settings 🔴 76/76 57/76 → 73/76
indices.put_mapping 🔴 128/132 → 129/132 135/135

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation changes for the APIs you have modified.

API Status Request Response
indices.create 🔴 1186/1240 → 1211/1240 1240/1240
indices.get_settings 🔴 76/76 57/76 → 73/76
indices.put_mapping 🔴 128/132 → 129/132 135/135

You can validate these APIs yourself by using the make validate target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants