-
Notifications
You must be signed in to change notification settings - Fork 101
Add 8.18 documentation URLs to schema and OpenAPI #4638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ea14a4
to
12a2e46
Compare
12a2e46
to
65dd240
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output and table.csv LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a nitpick.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4638-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6f0fe001aa90f0f79da7eac081c62ceffee99e7b
# Push it to GitHub
git push --set-upstream origin backport-4638-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
* Add 8.18 documentation URLs to schema and OpenAPI * generated files * rename legacy -> previous_version
Fixes #4369
The table.csv file now has a third column with the 8.18 documentation URL, if available. The mapping that was used comes from this spreadsheet.
These 8.18 docs URLs are imported in the new
extLegacyDocUrl
field of the schema. The OpenAPI generator then uses it to generate ax-legacyUrl
extension inside theDocumentation
object. The namex-legacyUrl
is made up by me, we can change it if there is a better suggestion, and in general, if there is a better word thanlegacy
to use for this information let me know and I'll replace it.