Skip to content

[test] split up ess and beats serverless integration tests #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented Jun 17, 2025

What does this PR do?

This PR introduces a CI pipeline update that splits the existing ECH-oriented integration tests into dedicated packages for improved modularity and execution flexibility. Specifically, it:

  • Introduces new test packages:
    • testing/integration/ess: contains ESS-targeting integration tests
    • testing/integration/serverless_beats: contains Beats-specific serverless integration tests
  • Updates the mage targets (integration:Test, integration:Matrix, integration:Single and integration:TestBeatServerless) to run the corresponding test packages.

Why is it important?

  • Improved modularity: Isolates tests specific to ECH and serverless flavors into their own packages, reducing the noise and tight coupling in the shared integration test package.
  • Better maintainability: Allows more focused test ownership and easier local test development.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

No user-facing disruption; internal test structure change only.

How to test this PR locally

for Beats serverless you need to have an already compiled filebeat

mage integration:auth
STACK_PROVISIONER=serverless mage integration:testBeatServerless filebeat
STACK_PROVISIONER=stateful TEST_PLATFORMS="windows/amd64" mage integration:single TestStandaloneUpgrade

Related issues

@pkoutsovasilis pkoutsovasilis self-assigned this Jun 17, 2025
@pkoutsovasilis pkoutsovasilis added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Jun 17, 2025
@pkoutsovasilis pkoutsovasilis force-pushed the feat/split_ess_integration_tests branch 2 times, most recently from e4e6a41 to cb5a016 Compare June 17, 2025 09:10
@elastic elastic deleted a comment from elasticmachine Jun 17, 2025
@pkoutsovasilis pkoutsovasilis force-pushed the feat/split_ess_integration_tests branch 3 times, most recently from db1dd0c to d1bf164 Compare June 19, 2025 20:46
@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review June 20, 2025 07:57
@pkoutsovasilis pkoutsovasilis requested review from a team as code owners June 20, 2025 07:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pkoutsovasilis pkoutsovasilis requested review from ycombinator and pchila and removed request for michalpristas June 20, 2025 07:57
pchila
pchila previously approved these changes Jun 20, 2025
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small nitpick (not blocking for merging) but code LGTM overall

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pkoutsovasilis

swiatekm
swiatekm previously approved these changes Jun 20, 2025
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split up ECH integration tests into dedicated package
4 participants