Skip to content

Add otel component manager to the coordinator #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Jun 16, 2025

What does this PR do?

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@swiatekm swiatekm added backport-8.19 Automated backport to the 8.19 branch skip-changelog chore Tasks that just need to be done, they are neither bug, nor enhancements labels Jun 16, 2025
@swiatekm swiatekm changed the title Chore/otel component manager Add otel component manager to the coordinator Jun 16, 2025

// MergedOtelConfig returns the merged Otel collector configuration, containing both the plain config and the
// component config.
MergedOtelConfig() *confmap.Conf
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is temporary, and is only necessary for diagnostics. The plan is to move all the Otel-related diagnostic hooks into the OtelComponentManager. Afterwards, there won't be any reason for the coordinator to track this value.

@swiatekm swiatekm force-pushed the chore/otel-component-manager branch from 379032c to 5275554 Compare June 17, 2025 09:43
Copy link

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @swiatekm

Copy link
Contributor

mergify bot commented Jun 18, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b chore/otel-component-manager upstream/chore/otel-component-manager
git merge upstream/main
git push upstream chore/otel-component-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch chore Tasks that just need to be done, they are neither bug, nor enhancements skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants