-
Notifications
You must be signed in to change notification settings - Fork 175
Add otel component manager to the coordinator #8529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
||
// MergedOtelConfig returns the merged Otel collector configuration, containing both the plain config and the | ||
// component config. | ||
MergedOtelConfig() *confmap.Conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This is temporary, and is only necessary for diagnostics. The plan is to move all the Otel-related diagnostic hooks into the OtelComponentManager. Afterwards, there won't be any reason for the coordinator to track this value.
379032c
to
5275554
Compare
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @swiatekm |
This pull request is now in conflicts. Could you fix it? 🙏
|
What does this PR do?
Why is it important?
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself