apm-server: Remove server information endpoint POST / support
#647
Conversation
| % :::: | ||
|
|
||
| ::::{dropdown} Change server information endpoint / to only accept GET and HEAD requests |
There was a problem hiding this comment.
In release-notes markdown, there's a comment
% Release notes include only features, enhancements, and fixes. Add breaking changes, deprecations, and known issues to the applicable release notes sections.
% For each new version section, include the Elastic APM and Kibana changes.
[to reviewer] so we're not supposed to mention breaking changes in release notes changelog, but only in this breaking changes section from now on? Asking as this is kind of different from what we did in <9.0. Also, there's no links to breaking changes from 9.0 release notes. I wonder if users would miss any breaking changes.
There was a problem hiding this comment.
From @KOTungseth:
Correct—the new structure separates breaking changes from the release notes changelog. Moving forward, breaking changes should only be documented in the "Breaking Changes" section, not in the general release notes. Since breaking changes appear in the left nav in the release notes section of our new IA [this is just a subset of release-note-related content as we wait for the dev work to be done related to assembling docs from all repos together], users can easily navigate and view these pages.
@KOTungseth can you share a link to more details about the release note strategy with @carsonip when it's ready? 🙏
There was a problem hiding this comment.
@colleenmcginnis sgtm. I believe this PR aligns with the strategy. Feel free to review and merge it.
| @@ -17,12 +17,19 @@ To learn how to upgrade, check out <uprade docs>. | |||
| % **Action**<br> Steps for mitigating deprecation impact. | |||
| % :::: | |||
|
|
|||
| % ## 9.0.0 [elastic-apm-900-breaking-changes] | |||
| % **Release date:** March 25, 2025 | |||
| ## 9.0.0 [elastic-apm-900-breaking-changes] | |||
There was a problem hiding this comment.
Let's update this to make it easier to distinguish major/minor/patch.
| ## 9.0.0 [elastic-apm-900-breaking-changes] | |
| ## 9.0.0 [elastic-apm-9-0-0-breaking-changes] |
| % ## 9.0.0 [elastic-apm-900-breaking-changes] | ||
| % **Release date:** March 25, 2025 | ||
| ## 9.0.0 [elastic-apm-900-breaking-changes] | ||
| **Release date:** March 25, 2025 |
There was a problem hiding this comment.
Are we ready to state the release date?
| % :::: | ||
|
|
||
| ::::{dropdown} Change server information endpoint / to only accept GET and HEAD requests |
There was a problem hiding this comment.
It's a bit confusing in the dropdown title since we can't format as /.
What do you think about this instead?
| ::::{dropdown} Change server information endpoint / to only accept GET and HEAD requests | |
| ::::{dropdown} Change server information endpoint "/" to only accept GET and HEAD requests |
|
|
||
| ::::{dropdown} Change server information endpoint / to only accept GET and HEAD requests | ||
| This will surface any agent misconfiguration causing data to be sent to `/` instead of the correct endpoint, e.g. `/v1/traces` for OTLP/HTTP. |
There was a problem hiding this comment.
| This will surface any agent misconfiguration causing data to be sent to `/` instead of the correct endpoint, e.g. `/v1/traces` for OTLP/HTTP. | |
| This will surface any agent misconfiguration causing data to be sent to `/` instead of the correct endpoint (for example, `/v1/traces` for OTLP/HTTP). |
| **Action**<br> Update any existing usage of e.g. `POST /` to `GET /`. |
There was a problem hiding this comment.
| **Impact**<br> Any methods other than GET and HEAD to `/` will return HTTP 405 Method Not Allowed. | |
| **Action**<br> Update any existing usage of e.g. `POST /` to `GET /`. | |
| **Impact**<br> Any methods other than `GET` and `HEAD` to `/` will return HTTP 405 Method Not Allowed. | |
| **Action**<br> Update any existing usage, for example, update `POST /` to `GET /`. |
Corresponding code change: elastic/apm-server#15976
Issue elastic/apm-server#15965