Skip to content

[8.19](backport #44892) x-pack/filebeat/input/gcppubsub: add support for proxy configuration #44940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 8.19
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 19, 2025

Proposed commit message

x-pack/filebeat/input/gcppubsub: add support for proxy configuration

This is a minimal addition for addition of proxy configuration. To
acheive this, the full httpcommon.HTTPTransportSettings struct is not
used since it brings defaults that may change behaviour for users.
Instead it uses a subset of the struct using otherwise zero values for
the rest when the proxy-aware client is constructed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #44892 done by [Mergify](https://mergify.com).

…44892)

This is a minimal addition for addition of proxy configuration. To
achieve this, the full httpcommon.HTTPTransportSettings struct is not
used since it brings defaults that may change behaviour for users.
Instead it uses a subset of the struct, otherwise using zero values for
the rest when the proxy-aware client is constructed.

(cherry picked from commit 875af7d)

# Conflicts:
#	docs/reference/filebeat/filebeat-input-gcp-pubsub.md
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 19, 2025
@mergify mergify bot requested review from a team as code owners June 19, 2025 20:44
@mergify mergify bot assigned efd6 Jun 19, 2025
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 19, 2025
Copy link
Contributor Author

mergify bot commented Jun 19, 2025

Cherry-pick of 875af7d has failed:

On branch mergify/bp/8.19/pr-44892
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 875af7d9e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   x-pack/filebeat/input/gcppubsub/config.go
	modified:   x-pack/filebeat/input/gcppubsub/input.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/reference/filebeat/filebeat-input-gcp-pubsub.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 19, 2025
@github-actions github-actions bot added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team labels Jun 19, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants