Skip to content

[8.19](backport #44923) [filebeat][GCS] - Added missing 'text/csv' content-type filter support #44929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 8.19
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 19, 2025

Type of change

  • Bug

Proposed commit message

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing 
each job. 

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #44923 done by [Mergify](https://mergify.com).

#44923)

Currently content-type "text/csv" did not have official filtering
support even though we support csv decoding. This made objects having this
content type defined were not picked up for processing. This PR as a "bugfix",
adds support for explicit "text/csv" content-type filtering while processing
each job.

(cherry picked from commit a2b74e8)

# Conflicts:
#	x-pack/filebeat/input/gcs/input_test.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 19, 2025
@mergify mergify bot requested a review from a team as a code owner June 19, 2025 12:21
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 19, 2025
Copy link
Contributor Author

mergify bot commented Jun 19, 2025

Cherry-pick of a2b74e8 has failed:

On branch mergify/bp/8.19/pr-44923
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit a2b74e866.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   x-pack/filebeat/input/gcs/mock/data_files.go
	modified:   x-pack/filebeat/input/gcs/mock/mock.go
	new file:   x-pack/filebeat/input/gcs/mock/testdata/txn1.csv
	modified:   x-pack/filebeat/input/gcs/types.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/filebeat/input/gcs/input_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 19, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 19, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG removed the conflicts There is a conflict in the backported pull request label Jun 20, 2025
@ShourieG
Copy link
Contributor

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants