-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon' module #43002
Conversation
be578af
to
87a145b
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the linter is happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about this part of the code, but looks good
… module (#43002) (#43069) * Add a new 'match_by_parent_instance' option to 'perfmon' module * Add type assertion check (cherry picked from commit 180bd96) Co-authored-by: Marc Guasch <[email protected]>
… module (#43002) (#43070) * Add a new 'match_by_parent_instance' option to 'perfmon' module * Add type assertion check (cherry picked from commit 180bd96) Co-authored-by: Marc Guasch <[email protected]>
…-packaging-steps * upstream/main: filebeat: make deep copy before notifying of config change (elastic#42992) [metricbeat] Add a new 'match_by_parent_instance' option to 'perfmon' module (elastic#43002) Don't package arm64 on amd64 workers (elastic#43026) [REVERT] Update Stack Monitoring data stream to 9 (elastic#43052) FIPS Build (elastic#42402) refactor: drop custom fsync implementation (elastic#42066) Update CHANGELOG.asciidoc docs: Prepare Changelog for 8.17.3 (elastic#42980) (elastic#43029) Fix boolean key in security pipelines and sync pipelines with integration. (elastic#43027) Skip test case for sequoia (elastic#42996) [main](backport elastic#42976) docs: Prepare Changelog for 8.16.5 (elastic#43005) x-pack/filebeat/input/entityanalytics/provider/activedirectory: do not consider computers to be users (elastic#42796)
Proposed commit message
Add a new 'match_by_parent_instance' option to 'perfmon' module. This will let users prevent instance names from dropping instance numbers.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.