-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Migrate docs from AsciiDoc to Markdown #42897
base: main
Are you sure you want to change the base?
Conversation
Reviewers, please let me know if you need any details about this. I assume that the failing CI checks don't matter, or the tests can be removed since they won't be applicable any longer with the new Markdown docs. Also, just for awareness, we'll have a 1:1 mapping so that each HTML docs page now has a single Markdown source file. Previously, changes in the 'libbeat' directory were propagated to the Metricbeat docs, Filebeat docs, etc. We're making similar changes across all of the docs to reduce complexity. |
@kilfoyle, yes, we still have generated docs and as far as I can tell we still need them. While the Generated docs is a bit outdated (e.g: So we have to update them to output Markdown and to stop relying on reading versions from |
Thanks @belimawr! If I should open an issue for those changes or if there's anything else I can do, please let me know. |
Yes, please, could you open an issue for that? Given your comment:
I understood you'd open the issue. Honestly, I'm not sure who is responsible for those scripts: the Data-Plane (Beats) team or the Docs team 🙈. Anyway, if there is anything I can help with, just ping me ;) |
Unfortunately, the Docs Eng team doesn’t have the bandwidth to update automation scripts for every engineering team 😞 . We know this work takes time to prioritize and schedule, so we can ship static docs (this point-in-time snapshot) for teams that need more runway while they update their automation. Ideally, we'd be able to do that from this repo. But it sounds like there’s some automation that needs fixing before we can merge this PR. @kilfoyle is meeting with @pierrehilbert on Friday. I've asked to be added to that meeting to continue the discussion. |
Thanks a lot @belimawr for the investigation and @bmorelli25 for the clarification! And sorry for my confusion: I wasn't sure which team should or could own this work. I've opened #43008 to see if we can:
If I've missed any info in the issue please feel free to make any additions/corrections. On Friday, Brandon and I will chat with Pierre about this issue and also the Beats Release Notes. |
This pull request is now in conflicts. Could you fix it? 🙏
|
Just to try and get some of the CI checks to pass I've temporarily re-added:
Unfortunately I don't think it helped. |
👋 @kilfoyle this is just a guess, but it looks like there were quite a few non-AsciiDoc files deleted (that's on me). I can try restoring them to see if that fixes the checks. |
Thanks, @colleenmcginnis! I'm seeing helpful error messages now about missing files used for docs automation. As a temporary solution to help us get this PR merged, I'm going to work on restoring the |
Signed-off-by: bmorelli25 <[email protected]>
I could use some help from a Beats engineer on understanding why golangci-lint / lint is failing even though none of those files are changed by this PR. |
This check is not required. It checks every file touched by the PR and will give warnings even if the lines were not added by the PR. If it is waning about lines you didn't touch, you can just ignore it. |
Migrate docs from AsciiDoc to Markdown.
Please see docs preview
Notes:
{beat}/docs/
directory.For reference, here are details about the docs migration.