Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17](backport #29751) #29747: Fix Add Network Direction processor #30124

Merged
merged 2 commits into from
Mar 15, 2022
Merged

[7.17](backport #29751) #29747: Fix Add Network Direction processor #30124

merged 2 commits into from
Mar 15, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 1, 2022 •
edited by zube bot
Loading

This is an automatic backport of pull request #29751 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@legoguy1000
#29747: Fix Add Network Direction processor (#29751)
14eb879 
Fix Add Network Direction processor field with dot in name.

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit 56b227d)
@mergify mergify bot added the backport label Feb 1, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 1, 2022
@botelastic
Copy link

botelastic bot commented Feb 1, 2022

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 1, 2022 •
edited by jenkins-beats-ci bot
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-15T19:53:55.443+0000

  • Duration: 83 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 360
Skipped 117
Total 477

Steps errors 4

Expand to view the steps failures

metricbeat-goIntegTest - mage goIntegTest
  • Took 31 min 49 sec . View more details here
  • Description: mage goIntegTest
metricbeat-goIntegTest - mage goIntegTest
  • Took 20 min 6 sec . View more details here
  • Description: mage goIntegTest
metricbeat-goIntegTest - mage goIntegTest
  • Took 21 min 59 sec . View more details here
  • Description: mage goIntegTest
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor Author

mergify bot commented Feb 11, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/7.17/pr-29751 upstream/mergify/bp/7.17/pr-29751
git merge upstream/7.17
git push upstream mergify/bp/7.17/pr-29751

@jsoriano
Copy link
Member

@andrewkroh is this backport needed in 7.17?

@andrewkroh andrewkroh self-assigned this Mar 15, 2022
@andrewkroh
Copy link
Member

Might as well fix it. Dots in keys are annoying.

@andrewkroh
Copy link
Member

/test

@andrewkroh
Copy link
Member

andrewkroh commented Mar 15, 2022 •
edited
Loading

Some unrelated failures in Metricbeat k8s module tests:

[2022-03-15T21:07:32.192Z] === Failed
[2022-03-15T21:07:32.192Z] === FAIL: metricbeat/module/kubernetes/controllermanager TestFetchMetricset (0.00s)
[2022-03-15T21:07:32.192Z]     controllermanager_integration_test.go:37: Expected 0 error, had 1. [error getting processed metrics: error making http request: Get "http://localhost:10252/metrics[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-30124/3/pipeline#step-1985-log-232)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-30124/3/pipeline#step-1985-log-233)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-30124/3/pipeline#step-1985-log-234)": dial tcp [::1]:10252: connect: connection refused]
[2022-03-15T21:07:32.192Z] 
[2022-03-15T21:07:32.192Z] === FAIL: metricbeat/module/kubernetes/scheduler TestFetchMetricset (0.01s)
[2022-03-15T21:07:32.192Z]     scheduler_integration_test.go:37: Expected 0 error, had 1. [error getting processed metrics: error making http request: Get "http://localhost:10251/metrics[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-30124/3/pipeline#step-1985-log-235)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-30124/3/pipeline#step-1985-log-236)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-30124/3/pipeline#step-1985-log-237)": dial tcp [::1]:10251: connect: connection refused]
[2022-03-15T21:07:32.192Z] 
[2022-03-15T21:07:32.192Z] DONE 32 tests, 2 failures in 76.774s
[2022-03-15T21:07:32.192Z] Error: failed modules: kubernetes

Issue: #30834

@andrewkroh andrewkroh merged commit 89b44ca into 7.17 Mar 15, 2022
@mergify mergify bot deleted the mergify/bp/7.17/pr-29751 branch March 15, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrewkroh andrewkroh

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elasticmachine @jsoriano @andrewkroh @legoguy1000