Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc, types): add DAS module with sampling stats and catch-up methods #557

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

YakupAltay
Copy link

Hey @zvolin!

While scanning through the issues, I noticed that not all Celestia Node API methods have been implemented in this issue.

I thought it would be helpful to add them step by step, so I started by implementing the two DAS methods. I’d love to get your feedback on whether this is the best approach moving forward.

Looking forward to your thoughts! I'm excited to contribute more.

@fl0rek
Copy link
Member

fl0rek commented Mar 7, 2025

@YakupAltay thanks for the contribution! 🎸

Looking at the CI failure, it seems you need to add a light node to our docker-compose setup. Please see Dockerfiles and shell scripts in that directory for reference, light node setup should hopefully look very similar. Or ping us if you need assistance :)

Additionally we require commits to be signed, so would you mind setting that up on your end, rebasing to sign commits you've pushed, and force pushing to replace them?

@YakupAltay
Copy link
Author

Hello @fl0rek!

Thanks for your insights.

I’ve tried to add a light node to the CI. Even though it should be very similar to the bridge node setup, I haven't been able to get the light node running yet. It keeps failing with the following error:
Error: node: failed to start: no trusted peers

It seems like the light node needs a boot node to start, and I’m trying to retrieve it from bridge-0. However, the following command fails:
peer_id=$(celestia p2p info --url 'ws://bridge-0:26658' | jq -r '.result.id')
It returns:
Error: cant access the auth token: token/node-store flag was not specified: no opened Node Store found (no node is running)

This happens even though the bridge node is definitely running.

I'd really appreciate any suggestions or pointers you might have! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants