Generic silicon pulse generation #1757
Open
+231
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Capybara summary for PR 1757
|
simonge
requested review from
kkauder,
a team and
veprbl
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Introduces a generic algorithm which will output a edm4hep::TimeSeries based on a function provided through the config. The interval of the time series needs to be equal to or below the fastest sampling to be used in digitization.
Built off the ToF implementation and using the Low-Q2 tagger as a demonstration.
Example plots of hits at different times and energies, red dot is the hit time:
To be followed by pulse combining and noise injection.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Outputs new collection containing a time series TaggerTrackerPulses for every hit in TaggerTrackerHits