Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated RP 10x130 matrix to use with new beamline settings #1753

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

ajentsch
Copy link
Contributor

@ajentsch ajentsch commented Mar 7, 2025

Briefly, what does this PR introduce?

Updates the 10x130 RP matrix to match the new beamline settings: eic/epic#839

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • [ x] Other: updated to match magnet settings

Please check if this PR fulfills the following:

  • [x ] Tests for the changes have been added
  • [x ] Documentation has been added / updated
  • [x ] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Yes, it will make the 10x130 RP reco correct for this energy setting with above magnet setting change.

Does this PR change default behavior?

Yes, see above.
RP_and_B0_pt_resolution_comparison_10_100_and_interpol_10_130_3_7_2025.pdf
pt_squared_and_RP_hit_plot_comparison_10_100_and_interpol_10_130_3_7_2025.pdf

@ajentsch ajentsch requested review from rahmans1 and veprbl March 7, 2025 17:39
veprbl
veprbl previously approved these changes Mar 10, 2025
@veprbl veprbl enabled auto-merge March 12, 2025 22:06
@veprbl veprbl added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit dba129a Mar 12, 2025
83 of 87 checks passed
@veprbl veprbl deleted the update-RP-matrix-for-ep-130 branch March 12, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants