feat: hide JANA2 implementation detail into JOmniFactory #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JOmniFactory supports either `std::vector<T*>` (with JANA2's `SetData<T>`) or podio containers (where `T` is now a container), but not the `ActsExamples::TrackContainer` container type which CKFTracking produces. This has resulted in CKFTracking creating a `std::vector<ActsExamples::TrackContainer*>`, but that implementation detail imposed by JOmniFactory has now propagated (no pun intended) to multiple other algorithms. This change aims to remove the implementation detail from the algorithms and into the JOmniFactory through a new `ContainerInput` and `ContainerOutput` that takes care of the wrapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
JOmniFactory supports either
std::vector<T*>(with JANA2'sSetData<T>) or podio containers (whereTis now a container), but not theActsExamples::TrackContainercontainer type which CKFTracking produces. This has resulted in CKFTracking creating astd::vector<ActsExamples::TrackContainer*>, but that implementation detail imposed by JOmniFactory has now propagated (no pun intended) to multiple other algorithms.This change aims to remove the implementation detail from the algorithms and into the JOmniFactory through a new
ContainerInputandContainerOutputthat takes care of the wrapping.What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.