ci: Add tests for PHP 8.4

[Chris53897]

No description provided.

[alamirault]

vimeo/psalm#10928 (comment) will be available "the next week."

(I can't unapprove now)

[egulias]

Hi @Chris53897 thanks for your PR. I have fixed the checks so please update with the latest code to have the checks pass.
Also, I believe that many deps are still not there for PHP8.4 but please double check.
Thanks!

[egulias]

Looks like at least psalm version needs to be bumped up.

[Chris53897]

i rebased now. Yes, we still ned to wait for vimeo

[egulias]

Thanks! Will wait for them then.

[egulias]

This will look awful... but I can't find where to re-run the checks!

[Chris53897]

You can just close and reopen this PR. CI will run againAm 06.03.2025 um 23:54 schrieb Eduardo Gulias Davis ***@***.***>: This will look awful... but I can't find where to re-run the checks!—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***> egulias left a comment (egulias/EmailValidator#390) This will look awful... but I can't find where to re-run the checks! —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for dcf8f791	✅ ∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (dcf8f79)	Report Missing	Report Missing	Report Missing
Head commit (ca3a476)	716	657	91.76%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#390)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[Chris53897]

"Just" 200 Errors from upgrading psalm.
Should i create a baseline and ignore them?

[egulias]

I guess we should fix them? I agree with final and have mixed feelings with override, which are basically the two things generating the 200 errors.