-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for file changes detection when running UI mode in Docker #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han just at startup
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
edumserrano
added a commit
that referenced
this pull request
Mar 10, 2024
…cker (#217) * regenerate package-lock.json * improve UI mode detection so that it also works when running outside of docker * wip detect wsl version for docker-desktop * wip detect wsl version for docker-desktop 2 * start docs for file change detection on docker * remove console log from playwright config because they trigger more than just at startup * Update docker README * Update docker README 2 * Update references to README section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In some cases, when running on Docker, file change detection will not be available which means the target test app doesn't get rebuild when you change the code. This is problematic when running the UI mode via Docker.
The root cause comes down to:
Possible solutions
--poll
option to theng serve
command executed by theplaywright.config.ts
. That's what is implemented by this PR.-useHostWebServer
option:-useHostWebServer
will make the tests running on Docker execute against the instance of the app running on the hostChanges
ng serve
command requires the--poll
flag.--poll
flag for theng serve
command .Footnotes
feat(webpackDevServer): Add watchOptions for webpackDevServer #1814 ↩
Nodemon and webpack-dev-server hot reload not working under WSL 2 after Windows 10 resinstall ↩