Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2011 Update Ubuntu on CI #2430

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Mar 8, 2025

Notes for Reviewer

From April 1st, Ubuntu 20.04 will not be supported anymore. This PR updates all Ubuntu Jobs to Ubuntu 24.04, except the integrationtests and code coverage jobs, which still rely on Ubuntu 22.04.

The standard Ubuntu job does now build with the standard gcc and cmake. Previously it tried to simulate a QNX build but that is not possible anymore since the old gcc is not supported on a newer Ubuntu. We still have the cirrus CI setup to simulate the QNX setup.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-2011-update-ubuntu-on-CI-for-main branch from 7d99c39 to 6ead64b Compare March 8, 2025 14:20
@elBoberido elBoberido changed the title iox-#2011 Update Ubuntu to 24.04 iox-#2011 Update Ubuntu on CI Mar 8, 2025
@elBoberido elBoberido force-pushed the iox-2011-update-ubuntu-on-CI-for-main branch from 6ead64b to 247196d Compare March 8, 2025 14:28
@elBoberido elBoberido self-assigned this Mar 8, 2025
@elBoberido elBoberido added the tooling All iceoryx related tooling (scripts etc.) label Mar 8, 2025
@elBoberido elBoberido force-pushed the iox-2011-update-ubuntu-on-CI-for-main branch 2 times, most recently from 777df7e to 73bb7e9 Compare March 9, 2025 10:54
@elBoberido elBoberido force-pushed the iox-2011-update-ubuntu-on-CI-for-main branch from 73bb7e9 to 5904c98 Compare March 9, 2025 17:28
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (c616c3b) to head (5904c98).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2430   +/-   ##
=======================================
  Coverage   78.68%   78.69%           
=======================================
  Files         440      440           
  Lines       16986    16988    +2     
  Branches     2361     2361           
=======================================
+ Hits        13366    13368    +2     
  Misses       2740     2740           
  Partials      880      880           
Flag Coverage Δ
unittests 78.49% <ø> (+<0.01%) ⬆️
unittests_timing 15.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elBoberido elBoberido merged commit 4449fcf into eclipse-iceoryx:main Mar 10, 2025
23 checks passed
@elBoberido elBoberido deleted the iox-2011-update-ubuntu-on-CI-for-main branch March 10, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants