Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a maven archetype module #63

Closed
wants to merge 2 commits into from

Conversation

hantsy
Copy link

@hantsy hantsy commented Mar 28, 2021

No description provided.

@hantsy
Copy link
Author

hantsy commented Mar 28, 2021

There are some questions about the maven archetype module.

  1. I need to set up the parent/child relation in this module?
  2. A better name for this module?
  3. The groupId is org.eclipse, it is better to use jakarta.starter or org.eclipse.ee4j.starter, I am not sure.
  4. CI for build the project. My original project is set to run build and tests in Github Actions.

Copy link
Member

@ivargrimstad ivargrimstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license header(s) must be fixed

@ivargrimstad
Copy link
Member

  1. The groupId is org.eclipse, it is better to use jakarta.starter or org.eclipse.ee4j.starter, I am not sure.
    The jakarta namespace is reserved for Jakarta EE specifications, so org.eclipse.starter is probably the most correct to use.

@eclipse-starter-bot
Copy link

Can one of the admins verify this patch?

@agoncal
Copy link

agoncal commented Feb 3, 2022

Hi. Any progress on that ? It would be great to have a Maven archetype to bootstrap a Jakarta EE 9 project.

@m-reza-rahman
Copy link
Contributor

Yes, PR forthcoming.

@m-reza-rahman
Copy link
Contributor

I think this PR can be withdrawn now @hantsy.

@m-reza-rahman
Copy link
Contributor

@ivargrimstad, I would suggest closing this PR. We've added Maven Archetypes now.

@hantsy hantsy closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants