Add paramiko to tests pip requirments

[mkemel]

Have run integration tests for the first time after F41 upgrade, and found that paramiko is never installed when installing all requirements according to the documentation, and is required by the tests.

[coveralls]

coverage: 83.252% (+0.1%) from 83.141%
when pulling 904f20e on mkemel:fix_test
into d5af188 on eclipse-bluechi:main.

[engelmi]

Good finding!
Could you also add pyyaml>=6.0.1? We use it in the CI (see here), but its missing in the requirements.txt as well.

[mwperina]

Good finding! Could you also add pyyaml>=6.0.1? We use it in the CI (see here), but its missing in the requirements.txt as well.

Hmm, paramiko is our own dependency for multihost feature, but pyyaml is an indirect dependency of tmt:

# dnf remove python3-pyyaml
Dependencies resolved.
==============================================================================================================================
 Package                                     Architecture    Version                    Repository                       Size
==============================================================================================================================
Removing:
 python3-pyyaml                              x86_64          6.0.1-14.fc40              @fedora                         786 k
Removing dependent packages:

...

 tmt+export-polarion                         noarch          1.38.0-1.fc40              @updates                        4.8 k
 tmt+link-jira                               noarch          1.38.0-1.fc40              @updates                        4.8 k
 tmt+provision-beaker                        noarch          1.38.0-1.fc40              @updates                        8.7 k
 tmt+provision-virtual                       noarch          1.38.0-1.fc40              @updates                        4.8 k
 tmt+report-junit                            noarch          1.38.0-1.fc40              @updates                        4.8 k
 tmt+report-polarion                         noarch          1.38.0-1.fc40              @updates                        4.8 k
 tmt+test-convert                            noarch          1.38.0-1.fc40              @updates                        4.8 k

So even though we have it in RPM installation section, we shouldn't be needing to have it there. So what am I missing?

Also is there a reason to use pip installation method when you are on F41?

[engelmi]

Hmm, paramiko is our own dependency for multihost feature, but pyyaml is an indirect dependency of tmt:

Fair point. I also see that pyyaml is a dependency of the tmt pip package - so it seems it really isn't needed to be listed explicitly. Not sure why we have the dedicated pyyaml dependency in the CI then, maybe it can be removed?

Also is there a reason to use pip installation method when you are on F41?

We support both options - installing via pip and rpm. Not sure why pip on F41 was used, but its true that we mention python3-paramiko in the rpm section and miss it in the pip requirements.txt.

[mwperina]

Hmm, paramiko is our own dependency for multihost feature, but pyyaml is an indirect dependency of tmt:

Fair point. I also see that pyyaml is a dependency of the tmt pip package - so it seems it really isn't needed to be listed explicitly. Not sure why we have the dedicated pyyaml dependency in the CI then, maybe it can be removed?

👍 to remove

Also is there a reason to use pip installation method when you are on F41?

We support both options - installing via pip and rpm. Not sure why pip on F41 was used, but its true that we mention python3-paramiko in the rpm section and miss it in the pip requirements.txt.

Sure, 👍 to have paramiko in requirements.txt

[mwperina]

LGTM

[mkemel]

Also is there a reason to use pip installation method when you are on F41?

Actually I realized only now that it's either dnf or pip packages, always been running both.
Looking at it again, i see that tmt-report-junit package is not available, that's why the whole command failed and didn't install paramiko. Turns out that it should be tmt+report-junit. Adding fix to the PR

[mkemel]

Fair point. I also see that pyyaml is a dependency of the tmt pip package - so it seems it really isn't needed to be listed explicitly. Not sure why we have the dedicated pyyaml dependency in the CI then, maybe it can be removed?

You mean remove it from CI pip install command?

[engelmi]

Fair point. I also see that pyyaml is a dependency of the tmt pip package - so it seems it really isn't needed to be listed explicitly. Not sure why we have the dedicated pyyaml dependency in the CI then, maybe it can be removed?

You mean remove it from CI pip install command?

Yes, we could remove pyyaml from the CI here:
https://github.com/eclipse-bluechi/bluechi/blob/main/.github/workflows/integration-tests.yml#L75
Not sure if the CI breaks nonetheless for some reason, but lets see 😁

[mkemel]

Well it breaks @engelmi

[mwperina]

LGTM

[engelmi]

LGTM