Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test validity of -v/--version option #752

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

mwperina
Copy link
Member

@mwperina mwperina commented Feb 19, 2024

  • Test validity of -v/--version option
  • Align RPM release with release reported by command line tools

Fixes: #753
Signed-off-by: Martin Perina [email protected]

@coveralls
Copy link

coveralls commented Feb 19, 2024

Coverage Status

coverage: 72.898% (+0.07%) from 72.824%
when pulling 548cc03 on mwperina:test-version-option
into 5965128 on eclipse-bluechi:main.

Tests, that bluechi-controller, bluechi-agent and bluechi-ctl contains
-v and --version options and that the version returned aligns with RPM
package version.

Signed-off-by: Martin Perina <[email protected]>
Make sure, that RPM release for snapshot builds is properly passed to
the build, so this release can be reported correctly in command line
tools.

Fixes: eclipse-bluechi#753
Signed-off-by: Martin Perina <[email protected]>
@mwperina mwperina force-pushed the test-version-option branch from b4f6a73 to 548cc03 Compare February 20, 2024 12:54
@mwperina
Copy link
Member Author

/packit build-failed

@mwperina
Copy link
Member Author

/packit rebuild-failed

@dougsland dougsland self-requested a review February 20, 2024 20:18
Copy link
Contributor

@dougsland dougsland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwperina mwperina merged commit 2327958 into eclipse-bluechi:main Feb 20, 2024
20 checks passed
@mwperina mwperina deleted the test-version-option branch February 20, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release reported by command line tools is not consistent with RPM release for snapshot builds
3 participants