add a comment for each PR about test coverage #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
force-pushed
the
add-coverage-comment
branch
from
190b8f1 to
bbcb265
Compare
engelmi
force-pushed
the
add-coverage-comment
branch
from
bbcb265 to
8769293
Compare
engelmi
force-pushed
the
add-coverage-comment
branch
3 times, most recently
from
2b9109d to
66af930
Compare
|
Shouldn't it add a comment in this PR already? |
As far as I've understand it no. The purpose of this separate workflow is that its executed in a "secure" context and that is only when its run from checking out the bluechi repo, not the fork. |
mkemel
approved these changes
Jan 8, 2024
mwperina
reviewed
Jan 8, 2024
Signed-off-by: Michael Engel <[email protected]>
engelmi
force-pushed
the
add-coverage-comment
branch
from
66af930 to
15c41b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the integration test workflow in GH to add a comment about the test coverage to a PR. For this, it uses https://github.com/romeovs/lcov-reporter-action. It also splits the results of tmt into tmt logs and coverage results (html report and info file).
Note 1:
This can later be further extended to
Note 2:
The comment won't appear in this PR since it first needs to be merged and the comment workflow be part of this repository.